check for http.NoBody as well as nil Body

[ajanata]

While converting some internal services to use HTTPS instead of HTTP, we were observing breakages related to having Transfer-Encoding: chunked and Content-Length: -1 on GET requests, which makes little sense. After some long debugging sessions, we finally located the cause: The internal Go http client is upgrading the request to HTTP2, and the code that determines the actual content length requires either a nil body or http.NoBody to send a Content-Length of 0. Since the check for http.NoBody was not here, an empty byte buffer was being created, which failed the checks and caused a Content-Length of -1 to be used elsewhere. Adding the check here fixes the problem for us.

(We use echo and it really does not like Content-Length: -1 when binding requests to structs, event for GET requests.)

[mna]

Thanks, the change looks good to me!

[wolfeidau]

@mna are you going to tag a new release for this? Would be amazing if you did. 🙏🏻 😄

[mna]

@wolfeidau done, thanks for the reminder!