Use math/rand global random source and deprecate PRNG global variable #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mna
reviewed
Mar 2, 2024
rehttp.go
Outdated
| PRNG.Int63n(int64(math.Min(float64(max), top))), | ||
| rand.Int63n(int64(math.Min(float64(max), top))), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Let's have this function call ExpJitterDelayWithRand and pass rand.Int63n as the generator function, so that the algorithm is implemented only in one place.
rng_pre120.go
Outdated
| // Only seed the global random source on versions prior to 1.20 since | ||
| // it's pre-seeded starting in 1.20 | ||
| func init() { | ||
| rand.Seed(time.Now().UnixNano()) |
There was a problem hiding this comment.
I don't think the package should do this - the caller might have seeded the global source with a known value to get deterministic results. I think we should document on ExpJitterDelay that it assumes the global source has been properly seeded by the caller.
justinrixx
force-pushed
the
concurrent-rand
branch
from
e0a54ae
to
ea41c06
Compare
|
All valid feedback. I should have recognized the duplication in Updated now and ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12