-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bs5 feedback #1339
Comments
Same for the |
This seems to be a choice of the bootstrap framework. Looking at the CSS rules they provide for the @media (min-width: 992px)
.container {
width: 970px;
}
@media (min-width: 768px)
.container {
width: 750px;
} While in bootstrap 5 it is: @media (min-width: 992px)
.container, .container-lg, .container-md, .container-sm {
max-width: 960px;
}
@media (min-width: 768px)
.container, .container-md, .container-sm {
max-width: 720px;
}
@media (min-width: 576px)
.container, .container-sm {
max-width: 540px;
} Changing this to the Edit: I found an old PR that addressed this default behavior for the bootstrap 3 template in #501 and here is how the custom CSS looked like: /* address 2K or 4K monitors when using bootstrap 3 */
@media (min-width: 1280px) {
.container {
width: 100%;
padding-left: 4ch;
padding-right: 4ch;
}
} We should forward-port this to the new template, since the goal is to replicate the older one, but using the new release of bootstrap. |
Surely the proper fix here is to use fluid containers as it does exactly what we're after, and then add Editing it is what we did last time but isn't really the right approach, in my eyes. |
Seconded. Side padding is |
Yes it would be, start and end, it was left and right back in BS4 😅 When I changed it to fluid I had no left or right Margin and the border on the viewing of a paste had no margin. How does yours look? Creating a paste looked ok. |
Anyone feel free to submit a PR (with screenshots) to fix it… |
Please see PR #1341 |
The problem
The new bs5 template has fixed width containers for the content of the webpage, where as the old bootstrap theme used to utilise the whole width of the browser. Also when the width is limited it makes the navbar items look strange as they are not in align with the page content.
Utilising the full width of the browser makes more sense when sharing code, less scrolling required, for long lines of code. I personally don't see a benefit in limiting the width of the page.
The solution
Change
section
elements of the page from usingcontainer
tocontainer-fluid
class.Alternatives
Use old theme, or create your own custom theme based on bs5 to change the class name
The text was updated successfully, but these errors were encountered: