-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password field is not reset when clicking 'New ' #1194
Comments
Yeah, I can imagine this. Since PrivateBin is kind of a SPA, that needs to be handled in a custom way. However, it should be as simple as clearing the input at the correct position. As such maybe a "good first issue" respectively if you want to do a PR, feel free. |
Hello there, can I take up this issue if it's still open ? |
Sure thing, go for it. The files changed in #612 should give you an idea what method you'd want to look at ( Line 4530 in f313578
|
Hello, I raised a pull request with the fix. However, it failed a compliance test. Could you let me know how to proceed ?
|
If I remember correctly, the issue with Snyk is that it requires a secret to use the service, which is of course stored in this project, but won't get cloned into forks. So unfortunately that scan only works for branches living in this project, but not for PRs coming from another forked repo. If anyone has an idea if github actions could be set up not to fire when the PR is not related to a branch of the same repo (or maybe simply by checking for the presence of that secret and skipping the workflow if it isn't) it would avoid confusion and reduce the noise. |
I found something similar regarding the snyk issue. It suggests to run the snyk workflow only if the PR comes from a cloned copy of the original repo rather than a fork. |
Did you use the FAQ section?
After creating a password protected paste, clicking on 'New' returns to the creation form.
In the form the password is already prefilled with the password used for the last created paste.
Because all the other fields are defaulted when clicking on 'New', I would also assume so for the password field.
Steps to reproduce
What happens
Password field is not emptied when clicking on 'New'
What should happen
Password field is emptied when clicking on 'New' as are all the other input fields
Additional information
There was a similar ticket in the past: #611
It mentioned also the password not being reset, the fix did not cover it though.
Basic information
I can reproduce this issue on https://privatebin.net: Yes
The text was updated successfully, but these errors were encountered: