Fix hardcoded diggingface for cancel digging

[Vinciepincie]

Previously the packet that cancels the digging was hardcoded to face 1. I don't see a reason why the cancelling face would be different than the digging face.

On a server i noticed the block often doesnt break anymore when breaking something with hand again after cancelling. With this change this issue doesnt seem to happen so it possibly triggered anticheat or some glitch before.

[zardoy]

I don't see a reason why the canceling face would be different than the digging face.

IMO MC protocol is absolutely nonsense in some scenarios, many things are hardcoded at the protocol level. Its better to look at the actual packets that the original client sends. In the case of block digging canceling (status 1) the face should always be 0 and not 1. Most probably some plugin on the server just checks the face against 1 and then kicks you for obvious reasons.

[zardoy]

@Vinciepincie did you get a chance to test with the proposed change? I had the same issue and imo this issue should be prioritized

[Vinciepincie]

@Vinciepincie did you get a chance to test with the proposed change? I had the same issue and imo this issue should be prioritized

Yes it seems to works fine now.
I also tested by sniffing packets with a vanilla client (1.20.4) with this tool https://github.com/adepierre/SniffCraft
and it's indeed hardcoded to 0 as you said

[zardoy]

@Vinciepincie so is this ready now?

[Vinciepincie]

@zardoy
yes

[rom1504]

seems valid to me

we need a lot more tests for this though