Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deflate and deflate-miniz features are the same? #35

Closed
torokati44 opened this issue Apr 23, 2024 · 2 comments
Closed

The deflate and deflate-miniz features are the same? #35

torokati44 opened this issue Apr 23, 2024 · 2 comments

Comments

@torokati44
Copy link

torokati44 commented Apr 23, 2024

I have an observation about these lines: https://github.com/Pr0methean/zip/blob/75691456272cd43d4b08210808af9d8756406851/Cargo.toml#L57-L58

The default feature of flate2 is rust_backend: https://github.com/rust-lang/flate2-rs/blob/ae784978ff22dea373cf820b3ef5fbc6e948de3f/Cargo.toml#L34

I suppose, since this: rust-lang/flate2-rs#216

So, the deflate and deflate-miniz features might be identical now? 🤔

(Somewhat related: #107)

@Pr0methean
Copy link
Member

Looks like they are indeed identical, and there's no longer a miniz.c back end.

@Pr0methean Pr0methean added the fix merged Fix is merged, but the issue will stay open until it's released. label Apr 24, 2024
This was referenced Apr 24, 2024
Pr0methean added a commit that referenced this issue Apr 28, 2024
@Pr0methean
Copy link
Member

Update: I've now restored the feature, but documented that it is deprecated in version 1.1.2.

@Pr0methean Pr0methean removed the fix merged Fix is merged, but the issue will stay open until it's released. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants