-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed release pipeline errors and switched to KS3 #24751
Merged
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
approved these changes
Jan 8, 2025
/azp run PowerShell-CI-linux |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run PowerShell-CI-macos |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run PowerShell-CI-static-analysis |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run PowerShell-CI-windows |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run PowerShell-Windows-Packaging-CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
jshigetomi
added a commit
that referenced
this pull request
Jan 8, 2025
* Fixed an error in the release pipeline * Fixed ReleaseTag and Version variable in validate packages * Switched from Netlock to KS3 --------- Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Fixed an error in the release pipeline * Fixed ReleaseTag and Version variable in validate packages * Switched from Netlock to KS3 --------- Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Fixed an error in the release pipeline * Fixed ReleaseTag and Version variable in validate packages * Switched from Netlock to KS3 --------- Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13
added a commit
that referenced
this pull request
Jan 17, 2025
* Fixed an error in the release pipeline * Fixed ReleaseTag and Version variable in validate packages * Switched from Netlock to KS3 --------- Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com> Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13
added a commit
that referenced
this pull request
Jan 17, 2025
* Fixed an error in the release pipeline * Fixed ReleaseTag and Version variable in validate packages * Switched from Netlock to KS3 --------- Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com> Co-authored-by: Justin Chung <chungjustin@microsoft.com>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BackPort-7.4.x-Done
BackPort-7.5.x-Done
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes several changes to the Azure Pipelines YAML files, focusing on updating variables and references to improve consistency and functionality.
Key changes include:
Variable Updates:
Network
value fromNetlock
toKS3
in theextends:
section of the.pipelines/PowerShell-Release-Official.yml
file.Output Variables:
steps:
in.pipelines/templates/release-SetReleaseTagandContainerName.yml
to useOutputReleaseTag.ReleaseTag
instead ofReleaseTag
and addedisOutput=true
to thevso[task.setvariable]
command.jobs:
in.pipelines/templates/release-create-msix.yml
to useOutputVersion.AzureVersion
instead ofAzureVersion
.$releaseVersion
in thejobs:
section of.pipelines/templates/release-githubtasks.yml
to strip the leading 'v' fromReleaseTag
.jobs:
in.pipelines/templates/release-validate-globaltools.yml
to useOutputVersion.Version
for both thedotnet tool install
command and the version check. [1] [2]jobs:
in.pipelines/templates/release-validate-packagenames.yml
to useOutputVersion.AzureVersion
instead ofAzureVersion
.jobs:
in.pipelines/templates/release-validate-sdk.yml
to useOutputVersion.Version
instead ofVersion
.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).