Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed release pipeline errors and switched to KS3 #24751

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Jan 8, 2025

PR Summary

This pull request includes several changes to the Azure Pipelines YAML files, focusing on updating variables and references to improve consistency and functionality.

Key changes include:

Variable Updates:

  • Updated the Network value from Netlock to KS3 in the extends: section of the .pipelines/PowerShell-Release-Official.yml file.

Output Variables:

  • Modified the steps: in .pipelines/templates/release-SetReleaseTagandContainerName.yml to use OutputReleaseTag.ReleaseTag instead of ReleaseTag and added isOutput=true to the vso[task.setvariable] command.
  • Updated the jobs: in .pipelines/templates/release-create-msix.yml to use OutputVersion.AzureVersion instead of AzureVersion.
  • Added a new variable $releaseVersion in the jobs: section of .pipelines/templates/release-githubtasks.yml to strip the leading 'v' from ReleaseTag.
  • Changed the jobs: in .pipelines/templates/release-validate-globaltools.yml to use OutputVersion.Version for both the dotnet tool install command and the version check. [1] [2]
  • Updated the jobs: in .pipelines/templates/release-validate-packagenames.yml to use OutputVersion.AzureVersion instead of AzureVersion.
  • Modified the jobs: in .pipelines/templates/release-validate-sdk.yml to use OutputVersion.Version instead of Version.

PR Context

PR Checklist

Sorry, something went wrong.

Justin Chung added 3 commits January 8, 2025 13:13

Verified

This commit was signed with the committer’s verified signature.
pt2121 Prat

Verified

This commit was signed with the committer’s verified signature.
pt2121 Prat
packages
@jshigetomi jshigetomi added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 8, 2025
@jshigetomi jshigetomi marked this pull request as ready for review January 8, 2025 19:19
@TravisEz13 TravisEz13 enabled auto-merge (squash) January 8, 2025 19:30
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13
Copy link
Member

/azp run PowerShell-CI-macos

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13
Copy link
Member

/azp run PowerShell-CI-static-analysis

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13
Copy link
Member

/azp run PowerShell-CI-windows

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13
Copy link
Member

/azp run PowerShell-Windows-Packaging-CI

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 merged commit 93d85f1 into PowerShell:master Jan 8, 2025
13 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Jan 8, 2025

📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

jshigetomi added a commit that referenced this pull request Jan 8, 2025
* Fixed an error in the release pipeline

* Fixed ReleaseTag and Version variable in validate
packages

* Switched from Netlock to KS3

---------

Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 pushed a commit that referenced this pull request Jan 17, 2025
* Fixed an error in the release pipeline

* Fixed ReleaseTag and Version variable in validate
packages

* Switched from Netlock to KS3

---------

Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 pushed a commit that referenced this pull request Jan 17, 2025
* Fixed an error in the release pipeline

* Fixed ReleaseTag and Version variable in validate
packages

* Switched from Netlock to KS3

---------

Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull request Jan 17, 2025
* Fixed an error in the release pipeline

* Fixed ReleaseTag and Version variable in validate
packages

* Switched from Netlock to KS3

---------

Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull request Jan 17, 2025
* Fixed an error in the release pipeline

* Fixed ReleaseTag and Version variable in validate
packages

* Switched from Netlock to KS3

---------

Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants