-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retry count in url #864
Conversation
Size Change: +1.01 kB (0%) Total Size: 712 kB
|
@@ -29,7 +32,7 @@ export const addParamsToURL = ( | |||
|
|||
export const encodePostData = (data: PostData | Uint8Array, options: Partial<XHROptions>): string | BlobPart | null => { | |||
if (options.blob && data.buffer) { | |||
return new Blob([data.buffer], { type: 'text/plain' }) | |||
return new Blob([_isUint8Array(data) ? data : data.buffer], { type: 'text/plain' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our JS tests were using snapshots here. And the snapshot was happily passing when this method returned the empty array for Uint8Arrays passed in
@daibhin @benjackwhite it's best to go through this one a commit at a time with hide whitespace on 🙈 |
During an incident we are sometimes flooded with retries from the JS SDK.
Or at least we believe we are. And, when we are we don't know how many retries there are.
Let's add the retry count to the URL so we can figure things out by inspecting the capture logs
Tested locally that I can still ingest events etc