fix: Don't delete existing flags on decide errors

[neilkakkar]

This seems to be off: the whole point of this library being stateful is to not bork when decide sporadically errors out.

This means flags can go stale if decide is down for a long time, but you wouldn't lose all flags - which can be a much bigger hindrance.

Changes

...

Checklist

• Tests for new code (see advice on the tests we use)
• Accounted for the impact of any changes across different browsers

[github-actions]

Size Change: +4.82 kB (0%)

Total Size: 2.31 MB

Filename	Size	Change
dist/array.full.js	159 kB	+1.21 kB (+1%)
dist/array.js	101 kB	+1.21 kB (+1%)
dist/es.js	101 kB	+1.21 kB (+1%)
dist/module.js	101 kB	+1.21 kB (+1%)

ℹ️ View Unchanged

Filename	Size
dist/recorder-v2.js	93.6 kB
dist/recorder.js	58.3 kB
lib/rrweb/dist/plugins/console-record.js	26.6 kB
lib/rrweb/dist/plugins/console-record.min.js	10.8 kB
lib/rrweb/dist/plugins/console-replay.js	12.7 kB
lib/rrweb/dist/plugins/console-replay.min.js	5.72 kB
lib/rrweb/dist/plugins/sequential-id-record.js	910 B
lib/rrweb/dist/plugins/sequential-id-record.min.js	417 B
lib/rrweb/dist/plugins/sequential-id-replay.js	1.24 kB
lib/rrweb/dist/plugins/sequential-id-replay.min.js	578 B
lib/rrweb/dist/record/rrweb-record-pack.js	31.4 kB
lib/rrweb/dist/record/rrweb-record-pack.min.js	10.7 kB
lib/rrweb/dist/record/rrweb-record.js	140 kB
lib/rrweb/dist/record/rrweb-record.min.js	51.7 kB
lib/rrweb/dist/replay/rrweb-replay-unpack.js	188 kB
lib/rrweb/dist/replay/rrweb-replay-unpack.min.js	71.1 kB
lib/rrweb/dist/replay/rrweb-replay.js	172 kB
lib/rrweb/dist/replay/rrweb-replay.min.js	66.4 kB
lib/rrweb/dist/rrweb-all.js	356 kB
lib/rrweb/dist/rrweb-all.min.js	133 kB
lib/rrweb/dist/rrweb.js	302 kB
lib/rrweb/dist/rrweb.min.js	116 kB
lib/rrweb/es/rrweb/ext/base64-arraybuffer/dist/base64-arraybuffer.es5.js	1.94 kB
lib/rrweb/es/rrweb/ext/mitt/dist/mitt.es.js	1.99 kB

_{compressed-size-action}

[neilkakkar]

Adding Marius & Ben as reviewers too - if you have any context why this should stick around

[benjackwhite]

Yeah you're right. Not sure why that's there... only think I wish is that there was a test for this....

[neilkakkar]

Yep yep, will add, alongside some rate limit specific handling 👀

[mariusandra]

🤷