-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add new question index to id map #1812
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added functionality to map survey question indices to their IDs in survey events, enabling query building without hardcoded IDs while maintaining backwards compatibility.
- Added
getSurveyIndexToIdMap
function in/src/extensions/surveys/surveys-utils.tsx
to create index-to-ID mappings - Integrated new
$survey_question_index_to_id
property in survey event payloads - Added comprehensive tests in
/playwright/surveys/response-capture.spec.ts
and/playwright/surveys/question-types.spec.ts
covering various survey types - Implemented skip handling for questions without IDs in the mapping logic
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: +259 B (+0.01%) Total Size: 3.57 MB
ℹ️ View Unchanged
|
@marandaneto @ioannisj confirmed with product analytics team, |
Changes
add a new map from question index to its ID to help build queries from just the survey event, without relying on hardcoded ids
Checklist