-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle non Error objects being passed to captureException #1806
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added host parameter to PostHog CLI commands and improved error handling for plain objects in exception capture.
- Added
--host=http://localhost:8010
parameter to sourcemap inject/upload commands in/playground/error-tracking/react-ts-esbuild/package.json
- Enhanced error handling in
src/posthog-core.ts
to properly handle plain objects with message properties as error values - Ensures more consistent error reporting by capturing message properties from object-type errors
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: +465 B (+0.01%) Total Size: 3.57 MB
ℹ️ View Unchanged
|
Changes
We do not handle value being an object, so let's make sure it's a string