fix: check url match twice because of potential race condition

[lucasheriques]

Changes

Also checks if the URL condition is matching before actually rendering it.

This is to test wether or not there's some sort of race condition where the survey is rendered on the correct URL, but the URL changes, and before we process that, the survey is already rendered.

Instance event where it happened. Survey is set to not sohw up in this event, but it did.

...

Checklist

• Tests for new code (see advice on the tests we use)
• Accounted for the impact of any changes across different browsers
• Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
posthog-js	✅ Ready (Inspect)	Visit Preview	Feb 7, 2025 1:06pm

[greptile-apps]

PR Summary

This PR adds a defensive URL matching check to prevent race conditions in survey rendering. Here's a concise summary of the key changes:

• Added secondary URL match verification in handlePopoverSurvey method before rendering surveys
• Prevents edge case where URL changes between initial survey matching and actual rendering
• Ensures surveys only display when URL conditions are still valid at render time
• Maintains backward compatibility while improving reliability of URL-based survey targeting

The change is focused and targeted at preventing incorrect survey displays due to timing issues between URL checks and rendering.

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[github-actions]

Size Change: +33 B (0%)

Total Size: 3.3 MB

Filename	Size	Change
dist/all-external-dependencies.js	215 kB	-1 B (0%)
dist/array.full.es5.js	267 kB	+7 B (0%)
dist/array.full.js	370 kB	+7 B (0%)
dist/array.full.no-external.js	369 kB	+7 B (0%)
dist/module.full.js	370 kB	+7 B (0%)
dist/module.full.no-external.js	369 kB	+7 B (0%)
dist/surveys.js	72.4 kB	-1 B (0%)

ℹ️ View Unchanged

Filename	Size
dist/array.js	183 kB
dist/array.no-external.js	181 kB
dist/customizations.full.js	13.8 kB
dist/dead-clicks-autocapture.js	14.5 kB
dist/exception-autocapture.js	9.48 kB
dist/external-scripts-loader.js	2.64 kB
dist/main.js	183 kB
dist/module.js	183 kB
dist/module.no-external.js	181 kB
dist/recorder-v2.js	115 kB
dist/recorder.js	115 kB
dist/surveys-preview.js	69.4 kB
dist/tracing-headers.js	1.76 kB
dist/web-vitals.js	10.4 kB

_{compressed-size-action}