Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct type comment #1721

Merged
merged 2 commits into from
Feb 6, 2025
Merged

chore: correct type comment #1721

merged 2 commits into from
Feb 6, 2025

Conversation

pauldambra
Copy link
Member

comment for some canvas options was incorrect

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Feb 6, 2025 2:10pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated documentation for canvas recording options in src/types.ts, clarifying default values and type specifications for canvasFps and canvasQuality parameters.

  • Updated canvasFps default value from 0 to null-ish, noting it defaults to 4 when enabled
  • Corrected canvasQuality type description to specify decimal string format between 0-1
  • Fixed canvasQuality default value from 0 to null-ish, noting it defaults to "0.4" when enabled
  • Improved accuracy of documentation to match actual implementation behavior

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

github-actions bot commented Feb 6, 2025

Size Change: 0 B

Total Size: 3.3 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 215 kB
dist/array.full.es5.js 267 kB
dist/array.full.js 370 kB
dist/array.full.no-external.js 369 kB
dist/array.js 183 kB
dist/array.no-external.js 181 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.5 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/main.js 183 kB
dist/module.full.js 370 kB
dist/module.full.no-external.js 369 kB
dist/module.js 183 kB
dist/module.no-external.js 181 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 69.4 kB
dist/surveys.js 72.4 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra merged commit c674ed8 into main Feb 6, 2025
29 checks passed
@pauldambra pauldambra deleted the chore/correct-comment branch February 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants