feat: customize button text, Close #72 #74
Conversation
meowtec
force-pushed
the
custom-message-button-text
branch
2 times, most recently
from
f067714
to
e8ee540
Compare
There was a problem hiding this comment.
Would it make sense to make common-controls-v6 the default feature? I don't care about any OS older than Windows 10 and maybe in extreme cases Windows 8.
EDIT: Or maybe remove the feature all together, I'll leave that for you to decide as I don't have a strong preference.
examples/msg-custom-buttons.rs
Outdated
| let res = rfd::MessageDialog::new() | ||
| .set_title("Msg!") | ||
| .set_description("Description!") | ||
| // .set_buttons(rfd::MessageButtons::Ok) |
There was a problem hiding this comment.
This comment looks unnecessary
|
Also WASM CI is complaining about wrong match patterns |
When an application use some other API from COMCTL32.dll, will this API be imcompatible? （It originally work well with COMCTL32.dll v5.8, but we force the app to use v6.) I don't know it because I am not a windows developer. I think it's better to keep the feature and make it default, collect feedback and consider to remove the feature and old API in the feature. |
meowtec
force-pushed
the
custom-message-button-text
branch
from
e8ee540
to
b8a446f
Compare
meowtec
force-pushed
the
custom-message-button-text
branch
from
b8a446f
to
ebc50a6
Compare
Use
TaskDialogIndirectto show the message dialog because it supports customizing button texts.Besides,
TaskDialogIndirecthas a nicer look thanMessageBoxW.MessageBoxW:
TaskDialogIndirect:
While
TaskDialogIndirectis only available with comctl32 version 6, but the OS inbox version is stuck at 5.x. (ref microsoft/windows-rs#1294 (comment))So I added a cargo feature named
common-controls-v6for enabling v6.The change has been tested on Windows, Linux and macOS, but not on WASM.