Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDG: decode URI before converting to PathBuf #70

Merged
merged 1 commit into from
Jun 4, 2022
Merged

XDG: decode URI before converting to PathBuf #70

merged 1 commit into from
Jun 4, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jun 4, 2022 •
edited

PolyMeilex
PolyMeilex approved these changes Jun 4, 2022
View reviewed changes
Copy link
Owner

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward enough, tested on gnome, and it works like a charm.
Code of the underlined crate also looks fine.

Thanks!

@Be-ing
Copy link
Contributor Author

Be-ing commented Jun 4, 2022

Merge and new release?

@PolyMeilex PolyMeilex merged commit 7e5c4b2 into PolyMeilex:master Jun 4, 2022
@Be-ing Be-ing deleted the uri_decode branch June 4, 2022 20:30
@Be-ing
Copy link
Contributor Author

Be-ing commented Jun 4, 2022

Thanks for the quick review and release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PolyMeilex PolyMeilex PolyMeilex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Be-ing @PolyMeilex