Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos parent for sync FileDialog #58

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Conversation

m11m
Copy link
Contributor

@m11m m11m commented Feb 27, 2022

I don't claim to know what I am doing, but here is something that worked for me. :)

Note: It does not result in the "sheet" behavior, but it does result in the "child window" behavior.

@m11m
Copy link
Contributor Author

m11m commented Feb 27, 2022

re: #53

@PolyMeilex
Copy link
Owner

Looks promising, does it produce child always on top of parent behavior?

@m11m
Copy link
Contributor Author

m11m commented Feb 27, 2022

I observe it working similarly to how it works without setting the child, except that when you move the parent window, the child moves along with it as a window group.

If the goal is to produce similarly behaving GUI but only different programming interface (async vs sync), then this will not get the same "sheet" behavior that happens in AsyncFileDialog https://developer.apple.com/design/human-interface-guidelines/macos/windows-and-views/sheets/

@PolyMeilex
Copy link
Owner

It's a good middle ground, sheet forces us to start an event loop, so I would like to avoid that in sync API if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants