Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding updated constructor parameter in hardhat-dao-fcc/contracts/governance_standard/TimeLock.sol contract #13

Closed
Tri-pathi opened this issue Dec 27, 2022 · 5 comments

Comments

@Tri-pathi
Copy link

#Discription of admin(address) in TimelockController
*TimelockController : A new admin constructor parameter has been added and that is assigned the admin role instead of the deployer account, so we should add here too as in current repo older version is being used which is not compilable .(#3722)
In Current TimeLock.sol
we have only three constructor parameters

  1. uint256 minDelay
  2. address[] memory proposer
  3. address[] memory executors

There should be address admin constructor parameter in updated contract to use current OpenZeppelin TimelockController

@Tarang-16
Copy link

Yeah! That's right!
If we do not provide admin parameter then it is showing the following error:

Wrong argument count for modifier invocation: 3 arguments given but expected 4.

@PatrickAlphaC please consider updating this in the lesson 17.

@PatrickAlphaC
Copy link
Owner

Thanks all, I saw a few PRs on this. Would love to get a PR from someone who also updates the TimeLock.sol contract for all 4 parameters!

@Tri-pathi
Copy link
Author

fine.... i will update this soon...

@Tri-pathi
Copy link
Author

@PatrickAlphaC just made a PR in dao-template by adding admin constructor and updating deploy script.Thanks

@PatrickAlphaC
Copy link
Owner

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants