Create sendoauth2.phps #2985
Merged
Create sendoauth2.phps #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth2 authentication for both Microsoft 365 Exchange email and Google Gmail. Client secrets and X.509 certificates are supported for Exchange. Client secrets are supported for Gmail. Authorization_code grant flow and client_credentials grant flow for SMTP are supported for Exchange. Authorization_code grant flow is supported for Gmail.
Synchro
requested changes
Nov 24, 2023
examples/sendoauth2.phps
Outdated
| */ | ||
|
|
||
| //Set the wrapper namespace | ||
| namespace decomplexity\SendOauth2; |
There was a problem hiding this comment.
This isn't the right way to work with external libraries. The namespace should be up to the developer, and if they want to use your class, they should import it using:
use decomplexity\SendOauth2\SendOauth2B;
Just as they do for PHPMailer.
examples/sendoauth2.phps
Outdated
| //Sender and recipients | ||
| $mail->setFrom('from@example.com', 'Mailer'); // 'Header' From address with optional sender name | ||
| $mail->addAddress('joe@example.net', 'Joe User'); //Add a recipient | ||
| $mail->addAddress('ellen@example.com'); //Name is optional |
There was a problem hiding this comment.
Since the purpose of this example is purely to demonstrate how to use your auth wrapper, I suggest removing anything that is covered in other examples, such as extra recipients, attachments, etc.
| $mail->Host = 'smtp.office365.com'; //Set the SMTP server (smtp.gmail.com for Gmail) | ||
| $mail->SMTPAuth = true; //Enable SMTP authentication | ||
| $mail->Username = 'user@example.com'; //SMTP username | ||
| $mail->SMTPSecure = PHPMailer::ENCRYPTION_STARTTLS; //Enable implicit TLS encryption |
There was a problem hiding this comment.
These days we should be recommending SMTPS on port 465, as per RFC8314:
$mail->SMTPSecure = PHPMailer::ENCRYPTION_SMTPS;
$mail->Port = 465;
examples/sendoauth2.phps
Outdated
|
|
||
| $mail->setOAuth($oauthTokenProvider); //Pass OAuthTokenProvider to PHPMailer | ||
|
|
||
| //Attachments |
There was a problem hiding this comment.
As mentioned above, I suggest removing these attachment lines.
Updated from @Synchro's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuth2 authentication for both Microsoft 365 Exchange email and Google Gmail. Client secrets and X.509 certificates are supported for Exchange. Client secrets are supported for Gmail. Authorization_code grant flow and client_credentials grant flow for SMTP are supported for Exchange. Authorization_code grant flow is supported for Gmail.