Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCompatibility is depending on the squizlabs version, which creates conflicts on vendor/bin/phpcs #1682

Closed
MetalArend opened this issue Feb 22, 2024 · 5 comments
Labels

Comments

@MetalArend
Copy link

Requiring the newest version of the new phpcs and then requiring this package, things seem to work without issues. But when running a composer install with the dev-dependencies, we end up with the installation trying to create the vendor/bin/phpcs file from both the squizlabs as well as the phpcsstandards vendor.

Is there some way to avoid the conflict? I can imagine it is not an easy thing to avoid with all the work going into moving to the new repository, but wanted to start the conversation and hear if maybe there's some easy way to fix it temporarily?

All the luck,
Bart.

@fredden
Copy link
Contributor

fredden commented Feb 22, 2024

@MetalArend please can you provide some information for how we can reproduce the problem you're describing?

@jrfnl jrfnl added the invalid label Feb 22, 2024
@jrfnl
Copy link
Member

jrfnl commented Feb 22, 2024

we end up with the installation trying to create the vendor/bin/phpcs file from both the squizlabs as well as the phpcsstandards vendor.

@MetalArend The only way I can think of that this could be happening, is that your project (or one of the external standards you use) has erronously switched to phpcstandards/php_codesniffer.

Get this reverted back to squizlabs/php_codesniffer and all will be fine.

This is due to people not reading.

As it said in the take-over announcement:

Note: I would recommend waiting to make the switch until the 3.8.0 release has been tagged. Watch releases on the new repo to automatically get notified of this. The changelog will contain the relevant information for making the switch.

And then it very clearly states in the PHP_CodeSniffer 3.8.0 release notes:

  • For Composer users, nothing changes.
    In contrast to earlier information, the squizlabs/php_codesniffer package now points to the new repository and everything will continue to work as before.

The temporarily registered phpcstandards/php_codesniffer Packagist name has already been marked as abandoned too, so this is user error, nothing else.

@jrfnl jrfnl closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
@MetalArend
Copy link
Author

Sorry.

@MetalArend
Copy link
Author

Thank you for your patience on responding to this. We indeed moved to the phpcsstandards/php_codesniffer package.

@jrfnl
Copy link
Member

jrfnl commented Feb 23, 2024

@MetalArend Hope you can get that reverted soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants