PHP 8.1 | Tokenizer/PHP: fix nullable type tokenization for readonly properties #908
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/tokenizer-php-nullable-types-on-php-8.1-readonly-properties
branch
from
03b9012 to
a0d63bf
Compare
…properties The `?` in a type for a `readonly` property declared without visibility, would be tokenized as `T_INLINE_THEN`, not `T_NULLABLE`. Fixed now. Includes perfunctory test. Realistically, a lot more tests are needed for the `T_NULLABLE` vs `T_INLINE_THEN` tokenization, but at least, this is a start and covers the current change.
jrfnl
force-pushed
the
feature/tokenizer-php-nullable-types-on-php-8.1-readonly-properties
branch
from
a0d63bf to
55bb12f
Compare
11 tasks
DanielEScherzer
approved these changes
Mar 31, 2025
jrfnl
deleted the
feature/tokenizer-php-nullable-types-on-php-8.1-readonly-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered while investigating something else.
The
?in a type for areadonlyproperty declared without visibility, would be tokenized asT_INLINE_THEN, notT_NULLABLE.Fixed now.
Includes perfunctory test.
Realistically, a lot more tests are needed for the
T_NULLABLEvsT_INLINE_THENtokenization, but at least, this is a start and covers the current change.Suggested changelog entry
Fixed tokenization of
?in nullable types for readonly properties.