-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPCBF: Show "No errors were found" when nothing needs to be fixed. #806
Comments
Sounds loosely related to #184, as part of which the exit code is likely to change. For the record, there are currently four situations possible:
These four situations are currently handled as follows:
As part of #184, the exit code for situation 2 should change to As for your proposal, if I understand it correctly, your intention is to change the message for situation 1 to "No errors were found" and to leave the other situations alone. Correct ? |
Yes, that's correct. Thinking about it further, I am wondering if "No coding violations were found" would be clearer for developers, as it's noticeably different even when scanning. Probably bike shedding.
I think both of these changes make sense:
I'm happy to make these changes is the associated PR if you give me the go ahead. |
Maybe even
Thanks for your thoughts on this. I'll keep it for consideration for issue #184.
The exit code changes cannot be combined with the current change as those need to be made in a major release, i.e. in |
I've pushed a change to |
Is your feature request related to a problem?
When running
phpcbf
against a clean code base, ie one following coding standards, the exit message isNo fixable errors were found
.In order to confirm the code base is clear of errors, one needs to also run
phpcs
to determine if any issues need to be manually fixed.As
phpcbf
has run the sniffs, it would be good to be informed if there are no errors found upon exit.Describe the solution you'd like
If the code base has no errors or warnings, output
No errors were found
in place ofNo fixable errors were found
.An alternative may be: No coding standards violations were found
Additional context (optional)
The text was updated successfully, but these errors were encountered: