Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuleInclusionAbsoluteWindowsTest: minor tweaks #685

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 15, 2024

Description

Another follow up on #663

  • Switching the test skipping from an inline condition to a PHPUnit annotation.
  • Adding the @group Windows annotation to ensure this test will run for code coverage on Windows in CI.

Suggested changelog entry

N/A

* Switching the test skipping from an inline condition to a PHPUnit annotation.
* Adding the `@group Windows` annotation to ensure this test will run for code coverage on Windows in CI.
@jrfnl jrfnl added this to the 3.11.1 milestone Nov 15, 2024
@jrfnl jrfnl merged commit e11d8f2 into master Nov 15, 2024
72 checks passed
@jrfnl jrfnl deleted the feature/ruleinclusionabsolutewindowstest-add-group branch November 15, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant