PHP 8.3 | Tokenizer/PHP: add support for readonly anonymous classes #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
php-8.3/tokenizer-readonly-anonymous-classes
branch
from
5e9de65
to
9f2c3c2
Compare
github-actions
bot
added
Status: has merge conflict
and removed
Status: has merge conflict
labels
jrfnl
force-pushed
the
php-8.3/tokenizer-readonly-anonymous-classes
branch
from
9f2c3c2
to
96bc9dd
Compare
jrfnl
force-pushed
the
php-8.3/tokenizer-readonly-anonymous-classes
branch
2 times, most recently
from
a39bce3
to
17293c7
Compare
|
Unless there are objections/someone leaves a comments on this PR, I will merge this tomorrow. |
PHP 8.3 introduced readonly anonymous classes, fixing an oversight in the PHP 8.2 introduction of readonly classes. As things were, for PHP 8.1+, the tokenizer would change the token code for the `readonly` keyword from `T_READONLY` to `T_STRING` in the "context sensitive keyword" layer, thinking it to be a class name. And for PHP < 8.1, the readonly polyfill would ignore the token as it being preceded by the `new` keyword would be seen as conflicting with the "context sensitive keyword" layer, which meant it would not be re-tokenized from `T_STRING` to `T_READONLY`. This commit fixes both. Includes adding tests in a number of pre-existing test classes to cover this change.
jrfnl
force-pushed
the
php-8.3/tokenizer-readonly-anonymous-classes
branch
from
17293c7
to
9244858
Compare
|
Rebased and made one more small tweak (limit the exception in the context sensitive keywords layer to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.3 introduced readonly anonymous classes, fixing an oversight in the PHP 8.2 introduction of readonly classes.
As things were, for PHP 8.1+, the tokenizer would change the token code for the
readonlykeyword fromT_READONLYtoT_STRINGin the "context sensitive keyword" layer, thinking it to be a class name.And for PHP < 8.1, the readonly polyfill would ignore the token as it being preceded by the
newkeyword would be seen as conflicting with the "context sensitive keyword" layer, which meant it would not be re-tokenized fromT_STRINGtoT_READONLY.This commit fixes both.
Includes adding tests in a number of pre-existing test classes to cover this change.
Suggested changelog entry
Related issues/external references
Related to #106
Types of changes