Runner: allow the Performance report when running phpcbf
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless there are objections/someone leaves a comments on this PR, I will merge this tomorrow. |
As things were, a `phpcbf` run overruled the `Config::$reports` setting / `--report=...` CLI arguments to always only show the `Cbf` report. As running the Performance report can also be useful for `phpcbf` (to find particularly slow fixers), I'm proposing to change the logic which overrules the reports setting for `phpcbf` to allow for displaying the `Performance` report as well (if requested).
jrfnl
force-pushed
the
feature/runner-allow-phpcbf-with-performance-report
branch
from
ceb885b
to
e59ef4b
Compare
|
Rebased without changes. Merging once the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As things were, a
phpcbfrun overruled theConfig::$reportssetting /--report=...CLI arguments to always only show theCbfreport.As running the Performance report can also be useful for
phpcbf(to find particularly slow fixers), I'm proposing to change the logic which overrules the reports setting forphpcbfto allow for displaying thePerformancereport as well (if requested).Suggested changelog entry
phpcbfrun.Related issues/external references
Related to #60
Types of changes