fix: Tokens::overrideRange() block cache pruning

[mvorisek]

critical fix #8228 as currently Tokens::overrideRange() might leave the block cache corrupted

needed for #8225

[kubawerlos]

critical fix

can you explain how it is different from a regular fix? It seems to me like unnecessary dramaturgy.

[mvorisek]

Of course - crtical = core bug that leads to a code corruption. Here the cache was able to get out of sync and thus answering wrong,

I stress this mainly because it should deserve a patch release after it is merged.

[kubawerlos]

Of course - crtical = core bug that leads to a code corruption

What code corruption? Fixer does not corrupt any file.

I stress this mainly because it should deserve a patch release after it is merged.

"Should"? Does some international law of bugfixing dictate this? I don't think so, then not "should", but "would be nice" or something. Every time you use the phrase "should" (or "must etc.) - and you do it quite often - you sound like someone ordering others (e.g. maintainers) what they are obligated to do, but, hello 👋🏼, this is open source, a place where all people are doing what they are doing in their free time, for free.

[mvorisek]

I would love to get this PR integrated ❤

[Wirone]

@mvorisek in our contribution guide you can see:

if you work on a bug fix, please start with reproducing the problem by adding failing test case(s). When you have failing test case(s), you can create pull request just to reproduce fail in the CI. Then you can provide fix in the subsequent commits, it will make code review easier. It's allowed to modify existing test cases in bug fix pull request, but only if current behavior is proved to be invalid.

Not only it proves there actually is a bug, but also saves reviewers' time 🙂.

Anyway, I checked it locally and confirmed the buggy behaviour. For those who like code representation more than tokens, the flow here is:

• There's a code <?php $a= [ ];
• Token 3 (whitespace before [) is replaced with [
• Token 5 (whitespace inside brackets) is replaced with ]
• The code now is <?php $a=[[]]; which is valid (syntax-wise), but right now if you want to get index of a block end for token 4 (opening bracket for inner []), it should result with 5, but results with 6, which comes from Tokens::$blockStartCache

Thanks for the fix 🍻!

[mvorisek]

Thank you very much, it took me almost a day to figure what was going on!