CI: Ensure php-cs-fixer PHP compatibility
#8235
Conversation
Wirone
force-pushed
the
codito/lint-main-script
branch
from
417fa46 to
59a4d4f
Compare
.github/workflows/ci.yml
Outdated
| - name: Setup PHP | ||
| uses: ./.github/composite-actions/setup-php | ||
| with: | ||
| version: 5.6 |
There was a problem hiding this comment.
| version: 5.6 | |
| version: 7.0 |
please don't retrofix this because of https://3v4l.org/7ESuc#v5.6.40 - the #8229 CS fixing would be then harder
the idea is PHP 5.6 is already unsupported (by the entry file) for a long time and the real usage is really super low
There was a problem hiding this comment.
It's up to @keradus - his will was to support 5.6 and I believe the lost support for it was unintentional. If we want to change BC promise to 7.0 then I am fine with it, but it's not up to me.
There was a problem hiding this comment.
The PHP 5.6 support was removed 3 years ago - 60a618f - it might be unintentional, but 3 years we did not received any report. Users are simply not using PHP 5.6 anymore and the users who do, they already know "the syntax error behaviour". So IMO the value added returning support after 3 years is negative as it will complicate CI (#8229).
There was a problem hiding this comment.
@mvorisek I know it and I agree with you, I just said it's not my decision 🙂.
There was a problem hiding this comment.
as shared in my original msg (ref), we should align which versions we shall support for entry point.
I'm OK to have 7.0+
|
thank you @Wirone |
This PR fixes backward compatibility for
php-cs-fixerentrypoint for PHP 5.6 that was unintentionally lost some time ago. Also it introduces CI job for ensuring BC promise is remained (before vs after).