Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set new_with_parentheses for anonymous_class to false in PER-CS2.0 #8140

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat: set new_with_parentheses for anonymous_class to false in PER-CS2.0 #8140

merged 4 commits into from
Aug 7, 2024
+79 −44

Conversation

bonroyage
Copy link
Contributor

The spec for PER CS 2.0 states in chapter 8 that anonymous classes without arguments must not have parentheses:

If the anonymous class has no arguments, the () after class MUST be omitted. For example:

<?php

// Brace on the same line
// No arguments
$instance = new class extends \Foo implements \HandleableInterface {
    // Class content
};

The inheritance from PSR12 currently sets the new_with_parentheses to true for both named and anonymous classes

PHP-CS-Fixer/src/RuleSet/Sets/PSR12Set.php

Line 45 in ed86702

'new_with_parentheses' => true,

bonroyage added 3 commits July 25, 2024 16:48
@bonroyage
Set new_with_parentheses for anonymous_class to false in PER-CS2.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
785b7d8
@bonroyage
Run code styler on source
dd0a451
@bonroyage
Update documentation
Loading
Loading status checks…
070a2a6
@coveralls
Copy link

coveralls commented Jul 25, 2024 •
edited
Loading

Coverage Status

coverage: 95.161%. remained the same
when pulling e145777 on bonroyage:new_with_parentheses
into ed86702 on PHP-CS-Fixer:master.

@bonroyage
Fix test for PHP 8.3
Loading
Loading status checks…
e145777
@bonroyage bonroyage changed the title Set new_with_parentheses for anonymous_class to false in PER-CS2.0 fix: Set new_with_parentheses for anonymous_class to false in PER-CS2.0 Jul 25, 2024
@keradus keradus mentioned this pull request Jul 31, 2024
Merged
@keradus
Copy link
Member

keradus commented Jul 31, 2024

side note:
we classify this as feature, not bugfix
ref https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/feature-or-bug.rst#feature

@keradus keradus changed the title fix: Set new_with_parentheses for anonymous_class to false in PER-CS2.0 feat: set new_with_parentheses for anonymous_class to false in PER-CS2.0 Jul 31, 2024
@bonroyage bonroyage mentioned this pull request Aug 1, 2024
Merged
derrabus added a commit to symfony/symfony that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
Loading
Loading status checks…
376e594 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/mailer that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
495f032 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/validator that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
d4c4b77 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
1c9fbd6 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/twig-bridge that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
3209891 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/serializer that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
447d048 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/security-bundle that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
e0f0da5 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/http-foundation that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
4187b64 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/security-core that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
d869b12 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/contracts that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
2b0994e 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/var-exporter that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
d61d363 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
2e38b26 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/mime that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
6f123f9 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/console that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
a228c54 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/form that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
e555dbd 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/messenger that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
a58a667 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/routing that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
e804a52 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
78c80ab 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/asset-mapper that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
b04b71c 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/error-handler that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
00574b8 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/security-http that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
7433635 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/var-dumper that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
d403f5f 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
symfony-splitter pushed a commit to symfony/cache that referenced this pull request Aug 6, 2024
@derrabus
minor #57901 Code style change in `@PER-CS2.0 affecting `@Symfony…
1d94828 
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
@keradus
Copy link
Member

keradus commented Aug 7, 2024

thanks @bonroyage

@keradus keradus merged commit 1ce9e24 into PHP-CS-Fixer:master Aug 7, 2024
29 checks passed
@bonroyage bonroyage deleted the new_with_parentheses branch August 7, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus

@keradus keradus

@SpacePossum SpacePossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bonroyage @coveralls @keradus @derrabus @SpacePossum