Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Improve Infection setup #7913

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Mar 26, 2024

  • Remove Infection before building PHAR
  • Run Infection step only for Pull Requests

@Wirone Wirone requested a review from keradus March 26, 2024 01:36
@Wirone Wirone self-assigned this Mar 26, 2024
@coveralls
Copy link

coveralls commented Mar 26, 2024

Coverage Status

coverage: 96.035%. remained the same
when pulling bfef10a on Wirone:codito/infection-appendix
into a6098f8 on PHP-CS-Fixer:master.

@Wirone Wirone enabled auto-merge (squash) March 26, 2024 02:01
@Wirone Wirone merged commit 3159e49 into PHP-CS-Fixer:master Mar 26, 2024
26 checks passed
@Wirone Wirone deleted the codito/infection-appendix branch March 26, 2024 02:06
@Wirone
Copy link
Member Author

Wirone commented Mar 26, 2024

FYI: for now it's a bit hacky as it still triggers the Infection job, but the actual step is skipped. It would be better if job wasn't included in the matrix at all, but I don't know how to do it properly. It can be improved later if needed.

@keradus
Copy link
Member

keradus commented Mar 26, 2024

I think it's fine.
Possible to move it to separate file and have condition for file and not for step, but maybe it's overkill (I'm not asking to follow this path)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants