chore: tests documentation classes #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
IMO adding tests for those classes does not add much value because the actual generated documentation can already serve this purpose. Checking generated changes with Git is quite trivial. This is also already checked in CI.
However, now that you have done the biggest part of the job to write the tests, I don't think maintaining them will be a burden so I'm fine merging this anyway.
keradus
reviewed
Feb 28, 2024
| * | ||
| * @var string[] | ||
| */ | ||
| private static $classesWithoutTests = [ |
|
thanks @kubawerlos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.