-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Proper build target for local Docker Compose #7834
fix: Proper build target for local Docker Compose #7834
Conversation
@keradus @julienfalque Actually we could use |
Yeah IMO it's better because, as you said, the runtime in dev and CI is (almost) exactly the same, even if there will always be some small differences. That's what we did at one of my previous jobs and it led to easier CI setup and much less CI specific failures. However this requires a good caching setup for Docker images to avoid rebuilding those everytime. My experience is based on Bitbucket Pipelines, which had a caching system that could only store one cache version, so it worked well as long as the Docker setup didn't change at all, in which case the images were rebuilt on every job until the cache expired or was manually removed. I don't know how easy that would be on GitHub. |
That's why I said it's something to do in a separate PR 😉. For now let's just fix local build and make sure it's always buildable. |
de0afa7
to
7919eaf
Compare
Since it's not possible to hide skipped jobs, it's better to have these jobs in separate workflows. Workflow `Release` can be later extended with official site publication, social media announcements etc.
7919eaf
to
3972250
Compare
Bug introduced in #7782, I probably had
compose.override.yml
and did not encounter this before. Now I wanted to check lower PHP versions because#7777
stopped working for <8.1 and got an error during build.To make sure it won't happen again, I've added new CI workflow that will test Docker Compose builds when PR has Docker-related changes, on
master
branch push and once a day as a scheduled pipeline.I've moved current Docker workflow to "Release" workflow, we can later add more jobs that should happen on tags (like publishing official page).