Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not use @large on method level #7832

Conversation

kubawerlos
Copy link
Contributor

Technically, this changes nothing, as "The @large annotation is an alias for @group large", but:

@large is equivalent to PHPUnit\Framework\Attributes\Large - see sebastianbergmann/phpunit#4502:

@large will be implemented as PHPUnit\Framework\Attributes\Large (only allowed on classes; @large was allowed on methods but it does not make sense to mix tests of different sizes in a test case class)

@group large is equivalent to #[Group('large')] and this is allowed on method level: https://github.com/sebastianbergmann/phpunit/blob/11.0.2/tests/end-to-end/_files/size-groups/SizeGroupsTest.php

@coveralls
Copy link

Coverage Status

coverage: 94.78%. remained the same
when pulling 6106311 on 6b7562617765726c6f73:do_not_use_large_on_method_level
into 0bb1e4b on PHP-CS-Fixer:master.

@Wirone Wirone merged commit 5bb439b into PHP-CS-Fixer:master Feb 9, 2024
25 checks passed
@Wirone Wirone deleted the do_not_use_large_on_method_level branch February 9, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants