Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MethodArgumentSpaceFixer - do not break heredoc/nowdoc #7828

Merged

Conversation

kubawerlos
Copy link
Contributor

Fixes #5487

@coveralls
Copy link

coveralls commented Feb 7, 2024

Coverage Status

coverage: 94.772%. remained the same
when pulling b551466 on 6b7562617765726c6f73:fix_MethodArgumentSpaceFixer
into db62eb3 on PHP-CS-Fixer:master.

@kubawerlos kubawerlos mentioned this pull request Feb 7, 2024
@Wirone
Copy link
Member

Wirone commented Feb 7, 2024

What's wrong with the PHP 8.4 job? The output seems unreadable 😞. Deprecations? Or more?

@kubawerlos
Copy link
Contributor Author

What's wrong with the PHP 8.4 job? The output seems unreadable 😞. Deprecations? Or more?

@Wirone new error message for some preg_* function, see #7829

@Wirone Wirone force-pushed the fix_MethodArgumentSpaceFixer branch from f4c2aea to b551466 Compare February 7, 2024 19:15
@Wirone Wirone enabled auto-merge (squash) February 7, 2024 19:15
@Wirone Wirone merged commit 13df1fc into PHP-CS-Fixer:master Feb 7, 2024
25 checks passed
@Wirone Wirone deleted the fix_MethodArgumentSpaceFixer branch February 7, 2024 19:21
@Wirone
Copy link
Member

Wirone commented Feb 7, 2024

Thanks @kubawerlos 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

method_argument_space fixer brakes formatting in heredoc
3 participants