fix: no_useless_concat_operator - do not break variable
#7827
+125
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiroh
changed the title
no_useless_concat_operatorno_useless_concat_operator - do not break variable
mvorisek
reviewed
Feb 7, 2024
mvorisek
reviewed
Feb 7, 2024
mvorisek
reviewed
Feb 7, 2024
Merged
julienfalque
reviewed
Feb 8, 2024
julienfalque
reviewed
Feb 9, 2024
tamiroh
commented
Feb 11, 2024
This reverts commit 8da1a9d.
|
@Wirone @julienfalque |
julienfalque
approved these changes
Mar 10, 2024
Comment on lines
+345
to
+348
| $allowedPatternsForSecondOperand = [ | ||
| '/^\s.*/', // e.g. " foo", ' bar', " $baz" | ||
| '/^-(?!\>)/', // e.g. "-foo", '-bar', "-$baz" | ||
| ]; |
There was a problem hiding this comment.
I think this will allow merging strings in less cases than would technically be possible but I'm guessing this will actually be very rare so good enough for me, we'll improve this later if needed.
There was a problem hiding this comment.
We can always think about making regexes configurable, so people can fine-tune this behaviour on their side 🙂.
|
I took a brief look on a diff, but mostly I rely on @julienfalque's review here - let's merge 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7826