Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use wrongly named arguments in data providers #7823

Merged

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Feb 6, 2024

PHPUnit v11 started supporting sebastianbergmann/phpunit#5225 and these 2 providers had keys misplaced.

Errors are visible at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/7797534997/job/21264325381?pr=7808:
image

@coveralls
Copy link

Coverage Status

coverage: 94.772%. remained the same
when pulling 9e63e36 on 6b7562617765726c6f73:fix_data_providers
into 7d399e3 on PHP-CS-Fixer:master.

@Wirone Wirone merged commit 60dbedb into PHP-CS-Fixer:master Feb 6, 2024
25 checks passed
@Wirone Wirone deleted the fix_data_providers branch February 6, 2024 19:13
@Wirone
Copy link
Member

Wirone commented Feb 6, 2024

Thanks @kubawerlos 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants