Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PhpdocListTypeFixer - support key types containing <…> #7817

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: PhpdocListTypeFixer - support key types containing <…> #7817

merged 1 commit into from
Feb 4, 2024

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Feb 4, 2024

This PR fixes these false positives:

-'<?php /** @var array<class-string<Foo>, bool> */'
+'<?php /** @var list<class-string<Foo>, bool> */'
-'<?php /** @var array<int<1, 10>, bool> */'
+'<?php /** @var list<int<1, 10>, bool> */'

@coveralls
Copy link

Coverage Status

coverage: 94.753%. remained the same
when pulling a9733c9 on gharlan:phpdoc-list-type
into 1fc90da on PHP-CS-Fixer:master.

Wirone
Wirone approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Before merging I would like to hear from @kubawerlos whether it's OK 🙂.

@Wirone Wirone merged commit fe8f7fd into PHP-CS-Fixer:master Feb 4, 2024
25 checks passed
@Wirone
Copy link
Member

Wirone commented Feb 4, 2024

Thank you @gharlan 🍻

@gharlan gharlan deleted the phpdoc-list-type branch February 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gharlan @coveralls @Wirone @kubawerlos