feat: Ability to remove unused imports from multi-use statements #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
added
kind/feature
topic/fqcn
Wirone
commented
Feb 4, 2024
Wirone
force-pushed
the
codito/grouped-unused-imports
branch
2 times, most recently
from
f4f9b7c
to
e909081
Compare
kubawerlos
approved these changes
Feb 6, 2024
julienfalque
reviewed
Feb 8, 2024
Wirone
force-pushed
the
codito/grouped-unused-imports
branch
from
1cc3419
to
a972d3c
Compare
It was working anyway, since `$hasNonEmptyTokenBefore[0]` was always an int (first token in current line or PHP open tag's index), and when `$hasNonEmptyTokenAfter[0]` was null (nothing after an import statement) it tried to clear range with `-1` as end index, which effectively led to 0 steps in for loop. With explicit condition we only avoid stepping into `clearRange()`, but still it's better 🙂.
Wirone
force-pushed
the
codito/grouped-unused-imports
branch
from
a7c6d87
to
99aa87b
Compare
julienfalque
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #7814 and that PR must be merged before.
This utilises chunk-based
NamespaceUseAnalysisto remove parts of the multi-use statements and can also clean whole statement if every chunk was removed.