Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some improvements around array typehints #7799

Merged
merged 4 commits into from
Feb 3, 2024

Conversation

keradus
Copy link
Member

@keradus keradus commented Feb 2, 2024

as we see, we shall not blindly apply, but rule is great to find the cases and pre-fill the fix.

unfortunately, PHPStan is not able to detect violations. (so we cannot apply the rule, run Stan, and assume all good if there was no error)

@coveralls
Copy link

coveralls commented Feb 2, 2024

Coverage Status

coverage: 94.753%. remained the same
when pulling 5d93602 on keradus:array2list
into d15cfea on PHP-CS-Fixer:master.

Copy link
Member

@julienfalque julienfalque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, PHPStan is not able to detect violations. (so we cannot apply the rule, run Stan, and assume all good if there was no error)

I think PHPStan checks list constraints when enabling bleeding edge, which is our case.

src/Utils.php Outdated Show resolved Hide resolved
@keradus keradus enabled auto-merge (squash) February 2, 2024 23:39
@keradus keradus merged commit aafe887 into PHP-CS-Fixer:master Feb 3, 2024
25 checks passed
@keradus keradus deleted the array2list branch February 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants