Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FullyQualifiedStrictTypesFixer - better support annotations in inline {} #7633

Merged
merged 2 commits into from Dec 28, 2023

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 27, 2023

I identified the issue, I didn't work to prepare the fix yet.

I faced this issue while working with Sf codebase.

@keradus keradus marked this pull request as ready for review December 28, 2023 16:12
@coveralls
Copy link

Coverage Status

coverage: 94.799%. remained the same
when pulling c7a865f on keradus:xxx_bug2
into 84821fd on PHP-CS-Fixer:master.

@keradus keradus changed the title fix: FullyQualifiedStrictTypesFixer - report bug fix: FullyQualifiedStrictTypesFixer - better support annotations in inline {} Dec 28, 2023
@keradus
Copy link
Member Author

keradus commented Dec 28, 2023

going to merge as-is, looks like merge of both PRs are not getting in conflict (i merged locally and no error on tests)

@keradus keradus merged commit 50e6a58 into PHP-CS-Fixer:master Dec 28, 2023
25 checks passed
@keradus keradus deleted the xxx_bug2 branch December 28, 2023 16:38
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants