Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce percentage bar as new default progress output #7603

Merged
merged 15 commits into from
Dec 29, 2023
Merged

feat: Introduce percentage bar as new default progress output #7603

merged 15 commits into from
Dec 29, 2023
+236 −25

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Dec 21, 2023 •
edited
Loading

Now it looks like this:

image

😎

@Wirone Wirone added kind/feature topic/I/O topic/core Core features of Fixer's engine labels Dec 21, 2023
@Wirone Wirone requested review from keradus and kubawerlos December 21, 2023 01:02
@Wirone Wirone self-assigned this Dec 21, 2023
@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Coverage Status

coverage: 94.773% (-0.005%) from 94.778%
when pulling 6c24c03 on Wirone:codito/progress-bar
into 5ea7c20 on PHP-CS-Fixer:master.

@Wirone Wirone force-pushed the codito/progress-bar branch from 4161e79 to 347f30e Compare December 21, 2023 01:41
keradus
keradus reviewed Dec 22, 2023
View reviewed changes
@Wirone Wirone force-pushed the codito/progress-bar branch from ed0bbe8 to 940d2c2 Compare December 22, 2023 21:39
@Wirone Wirone enabled auto-merge (squash) December 23, 2023 15:16
@Wirone Wirone marked this pull request as draft December 27, 2023 14:10
auto-merge was automatically disabled December 27, 2023 14:10

Pull request was converted to draft

@Wirone Wirone force-pushed the codito/progress-bar branch from 01cf0d5 to 1b60ae5 Compare December 28, 2023 23:27
@Wirone Wirone marked this pull request as ready for review December 28, 2023 23:30
@Wirone Wirone requested a review from keradus December 28, 2023 23:30
keradus
keradus reviewed Dec 29, 2023
View reviewed changes
keradus
keradus reviewed Dec 29, 2023
View reviewed changes
keradus
keradus approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good. some minor issues with docs

Wirone and others added 4 commits December 29, 2023 18:49
@Wirone
Introduce percentage bar as progress output
0a40cbb
@Wirone
Make bar progress output default (even for non-verbose)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1406de7
@Wirone
Fix smoke tests

Verified

This commit was signed with the committer’s verified signature.
jhamman Joe Hamman
GPG key ID: 189C448BC947D459
Verified
Learn about vigilant mode
4aded9b
@Wirone @keradus
Improve array shape for progress output map

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5ab820c 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@Wirone Wirone force-pushed the codito/progress-bar branch from 1b60ae5 to 6c24c03 Compare December 29, 2023 17:55
@Wirone Wirone enabled auto-merge (squash) December 29, 2023 17:56
@Wirone Wirone merged commit cfdeac1 into PHP-CS-Fixer:master Dec 29, 2023
@Wirone Wirone deleted the codito/progress-bar branch December 29, 2023 18:04
@verfriemelt-dot-org
Copy link
Contributor

sooo nice :) 🚀

@mvorisek mvorisek mentioned this pull request Dec 30, 2023
Closed
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
@Wirone @keradus @danog
feat: Introduce percentage bar as new default progress output (PHP-CS…
8890a2d 
…-Fixer#7603)

Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus

@kubawerlos kubawerlos

Assignees

@Wirone Wirone

Labels
kind/feature topic/core Core features of Fixer's engine topic/I/O
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Wirone @coveralls @verfriemelt-dot-org @keradus