DX: PsrAutoloadingFixerTest - do not build mock in data provider #7491
Conversation
| @@ -382,7 +382,14 @@ final protected static function getTestFile(string $filename = __FILE__): \SplFi | |||
| { | |||
| static $files = []; | |||
|
|
|||
| return $files[$filename] ?? $files[$filename] = new \SplFileInfo($filename); | |||
| return $files[$filename] ?? $files[$filename] = new class($filename) extends \SplFileInfo { | |||
| public function getRealPath(): string | |||
There was a problem hiding this comment.
Because of the failed tests in the 1st commit.
There was a problem hiding this comment.
sorry but that is not the answer. It is basically "kerad, check it yourself" :(
if test from single test class is failing, because of custom logic that was originally isolated to given test class, i do not believe we should move that to affect test cases for all the rules
There was a problem hiding this comment.
i do not believe we should move that to affect test cases for all the rules
what if it affects it positive way?
There was a problem hiding this comment.
it's affect in surprising way. we effectively override logic of built-in method to not return false on non-existing file.
There was a problem hiding this comment.
to not return false on non-existing file
non-existing, like a mock file?
No description provided.