Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Update PHPStan to 1.10.46 #7486

Merged
merged 1 commit into from Dec 1, 2023

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Dec 1, 2023

Hopefully it fixes an issue in #7402, which looks like PHPStan's internal error.

@Wirone Wirone added the topic/ci Github Actions, tooling label Dec 1, 2023
@Wirone Wirone requested a review from keradus December 1, 2023 10:36
@Wirone Wirone self-assigned this Dec 1, 2023
@coveralls
Copy link

coveralls commented Dec 1, 2023

Coverage Status

coverage: 94.918%. remained the same
when pulling 9a74e01 on Wirone:codito/update-phpstan
into 37f703e on PHP-CS-Fixer:master.

@kubawerlos
Copy link
Contributor

Upgrading PHPStan never fix its issue on master as we unlock it there.

I guess latest issue is because Symfony 7 compoments are used. And fix is actually very simple: #7488

@Wirone
Copy link
Member Author

Wirone commented Dec 1, 2023

Yeah, for me it looked more like an internal issue, but I just forgot that error formatter is changed in the CI job, so it displays errors differently 🤦‍♂️. It's not friendly that the job's output does not display a file that is causing an error, you need to go to the summary 🤷‍♂️.

@Wirone Wirone enabled auto-merge (squash) December 1, 2023 11:55
@Wirone Wirone merged commit f4e10e0 into PHP-CS-Fixer:master Dec 1, 2023
25 checks passed
@Wirone Wirone deleted the codito/update-phpstan branch December 1, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ci Github Actions, tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants