chore: Make YAML workflow git-based #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Nov 26, 2023
Comment on lines
-6
to
+7
| - '**.y?ml' | ||
| - '**.yml' | ||
| - '**.yaml' |
There was a problem hiding this comment.
Explicit is better than implicit.
Wirone
approved these changes
Nov 26, 2023
| @@ -21,4 +23,4 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Run yamllint | |||
| run: find . -path \*/vendor -prune -false -o -name \*.y*ml | xargs yamllint | |||
| run: git ls-files --cached -z -- '*.y*ml' | xargs --null -- yamllint | |||
There was a problem hiding this comment.
Explanation:
-zquotes filenames with special characters and separates each path with NUL byte (that's why when you call this in CLI you get one long string, instead of multiple lines)xargs --nullthen handles this NUL byte and applies YAML linter to each file
I am not 100% sure if it's needed here, we could use git ls-files without -z and then xargs would work on new lines. But both ways work, so 👍.
There was a problem hiding this comment.
I cannot take the risk of having space - or line end - characters in file names.
Sorry. My speciality is the unhappy path. I run (not build) things.
There was a problem hiding this comment.
I believe we don't have files with spaces in name, but yeah, your approach is better here:
|
Thanks @szepeviktor 🍻 |
|
Glad to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findworks on the filesystem,gitworks on git index.source