Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix YAML line length #7476

Merged
merged 3 commits into from Nov 28, 2023
Merged

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 26, 2023

Now we don't have any warnings.
(YAML line folding)

@szepeviktor szepeviktor changed the title Fix YAML line length chore: Fix YAML line length Nov 26, 2023
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone is interested, here's an explanation of new line handling in YAML. Basically after this change the text in the Stale Bot's comments will be the same as before, only CI won't have warnings.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 26, 2023

viktor must know how things really work (down to byte level)
https://yaml.org/spec/1.2.2/

There could be viktor-like people out there! (or not)

@Wirone
Copy link
Member

Wirone commented Nov 26, 2023

Specs are great, in terms of knowledge and size 😉. That particular SO answer contains links to YAML specs, so it's easy to jump into fundamentals, while having essential info summarised.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 26, 2023

having essential info summarised

I wish I would be fit for talking to people having summarised info!!
I've tried but it always turned out to be a miscommunication 😢

@Wirone
Copy link
Member

Wirone commented Nov 26, 2023

Anyway, fail in the CI is related to shivammathur/setup-php#789 and I don't have sufficient permissions to merge your PRs ignoring the failed workflow. We need to wait for the fix in the upstream or for @keradus.

Thanks for all the contributions!

@coveralls
Copy link

Coverage Status

coverage: 94.922%. remained the same
when pulling e320f30 on szepeviktor:patch-2
into e1672a4 on PHP-CS-Fixer:master.

@keradus
Copy link
Member

keradus commented Nov 26, 2023

green now

@kubawerlos kubawerlos merged commit 81d5d9e into PHP-CS-Fixer:master Nov 28, 2023
26 checks passed
@kubawerlos
Copy link
Contributor

Thank you @szepeviktor

@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the patch-2 branch November 28, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants