Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ClassAttributesSeparationFixer - handle Disjunctive Normal Form types parentheses #7428

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: ClassAttributesSeparationFixer - handle Disjunctive Normal Form types parentheses #7428

merged 2 commits into from
Nov 9, 2023

Conversation

kubawerlos
Copy link
Contributor

Fixes #7427

@kubawerlos kubawerlos marked this pull request as ready for review November 9, 2023 13:52
@coveralls
Copy link

Coverage Status

coverage: 94.521%. remained the same
when pulling 17bd2e4 on 6b7562617765726c6f73:fix_ClassAttributesSeparationFixer
into bd6b372 on PHP-CS-Fixer:master.

@Wirone Wirone merged commit d9996a1 into PHP-CS-Fixer:master Nov 9, 2023
21 checks passed
@Wirone
Copy link
Member

Wirone commented Nov 9, 2023

Thank you @kubawerlos 🍻

@kubawerlos kubawerlos deleted the fix_ClassAttributesSeparationFixer branch November 9, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClassAttributesSeparationFixer bugged when there are parenthases in property type
3 participants
@kubawerlos @coveralls @Wirone