Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: conditionally install flex #7412

Merged
merged 6 commits into from Nov 3, 2023
Merged

CI: conditionally install flex #7412

merged 6 commits into from Nov 3, 2023

Conversation

keradus
Copy link
Member

@keradus keradus commented Nov 2, 2023

closes #7410

@keradus
Copy link
Member Author

keradus commented Nov 2, 2023

most jobs don't require flex.

  • example of PHP 8 job with flex: 12s

  • same job without flex: 4s

@keradus keradus marked this pull request as ready for review November 2, 2023 23:48
keradus
keradus commented Nov 2, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
keradus
keradus commented Nov 3, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
keradus
keradus commented Nov 3, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
keradus
keradus commented Nov 3, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 94.578%. remained the same
when pulling 3ea4f12 on keradus:flex
into a7cdc0a on PHP-CS-Fixer:master.

@keradus keradus merged commit 77103ef into PHP-CS-Fixer:master Nov 3, 2023
23 checks passed
@keradus keradus deleted the flex branch November 3, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

idea: drop Flex
2 participants
@keradus @coveralls