Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Improve QA process - suplement #7411

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Nov 2, 2023

Small improvements pointed out in #7366 (which was merged anyway).

The flags are disjunctive and are dedicated for different steps, but technically it would be possible to enable both for the same matrix item, which would lead to running regular tests AND another tests with code coverage.
I believe it could be still there, but it does not differ that much, and we already run these checks with newer deps on higher PHP versions.
@Wirone Wirone added the topic/ci Github Actions, tooling label Nov 2, 2023
@Wirone Wirone requested a review from keradus November 2, 2023 22:36
@Wirone Wirone self-assigned this Nov 2, 2023
@keradus keradus changed the title DX: Improve QA process - suplement CI: Improve QA process - suplement Nov 2, 2023
@keradus keradus merged commit b176b25 into PHP-CS-Fixer:master Nov 2, 2023
21 of 22 checks passed
@Wirone Wirone deleted the codito/improve-qa-process branch November 2, 2023 22:44
@Wirone
Copy link
Member Author

Wirone commented Nov 2, 2023

@keradus project has to be reconfigured in terms of required jobs (currently non-existing jobs are defined as required, which leads to unreported jobs that blocks merging, at least for us) 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ci Github Actions, tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants