feat: @Symfony - keep Annotation,NamedArgumentConstructor,Target annotations as single group
#7399
Conversation
…notations as single group
| 'phpdoc_separation' => [ | ||
| 'groups' => [ | ||
| ...PhpdocSeparationFixer::OPTION_GROUPS_DEFAULT, | ||
| ['Annotation', 'NamedArgumentConstructor', 'Target'], |
There was a problem hiding this comment.
I would say that grouping those would also belong to a doctrine annotations ruleset, as they relate to the usage of doctrine annotations.
There was a problem hiding this comment.
I think its valid point,
yet phpdoc_separation is not currently in use by @DoctrineAnnotation and I'm not sure if we want to start using it there.
There is tricky point of rule getting override if multiple rulesets are using it, and maybe it's not a top priority to solve it now. Doctrine ruleset could benefit from even bigger cleanup - especially about annotations -> attributes.
I'm not user of Doctrine and won't be able to judge there. Maybe we improve ruleset of Sf in first step, and if anyone would like to also take closer look to improve ruleset of Doctrine, we can have that as follow-up PRs (also very open if you are up for implementing something for Doctrine settings/rules)
There was a problem hiding this comment.
Well, the @DoctrineAnnotation is about doctrine/annotations IMO, so it should not care about attributes.
There was a problem hiding this comment.
yeah, it's probably like who effort to cleanup current rules, create rules that migrate anno to attrib, make sure rules works for both (or have sibling rule), ....
big thing I don't wan to mess myself, as not knowing that ecosystem.
ref symfony/symfony#52389