feat: Add ordered_types to @Symfony

[VincentLanglet]

Hi @Wirone

Symfony coding style already use:

'phpdoc_types_order' => [
                'null_adjustment' => 'always_last',
                'sort_algorithm' => 'none',
            ]

so I assume same should be applied to the types, ie:

'ordered_types' => [
                'null_adjustment' => 'always_last',
                'sort_algorithm' => 'none',
            ]

[coveralls]

coverage: 94.751% (+0.001%) from 94.75%
when pulling 556d3eb on VincentLanglet:orderTypeSymfony
into d12282c on PHP-CS-Fixer:master.

[VincentLanglet]

I'm not sure to understand the failures...

[SpacePossum]

The failures are a side effect of your changes.
The test tests/Fixtures/Integration/misc/PHP8_2.test is run with the configuration @PhpCsFixer which contains/extends itself the Symfony set. Since you changed the SF set the new configuration is applied on the tests/Fixtures/Integration/misc/PHP8_2.test.

The diff now looks like:

-function falsyNull(null $n, false $f): null|false {}
+function falsyNull(null $n, false $f): false|null {}

Now this expected since you've changed the configuration, however you didn't update the expected output for the test, hence it fails. So the fix would be to update the expected output for the test file and all should be fine :)

[VincentLanglet]

Thanks

[SpacePossum]

Might be worth running on latest SF src and see how many hits there are and/or align with SF team, anyways, change look good to me, so I would welcome these :)

[VincentLanglet]

Might be worth running on latest SF src and see how many hits there are and/or align with SF team, anyways, change look good to me, so I would welcome these :)

I found 8 occurences of null| and tons of |null

[SpacePossum]

thanks, sounds like a good thing you got here :)

[Wirone]

@nicolas-grekas can you confirm we can safely add it? @VincentLanglet did you try to run it against Symfony codebase?

[keradus]

@VincentLanglet , no need to poke me for review.
the missing element here is voice of Symfony to declare if they want to extend SymfonySet this way , eg #7356 (comment)

[VincentLanglet]

Maybe @OskarStark you could say if it's ok to add this to the Symfony standard or ping someone who could decide

[OskarStark]

I will bring this PR to the core-Team, let's wait a decision.

[VincentLanglet]

I will bring this PR to the core-Team, let's wait a decision.

Any news @OskarStark ? ^^'

[keradus]

vide symfony/symfony#53544

[keradus]

Accepted by SF community

[keradus]

would be good to cover this set change in test.
ie tests/Fixtures/Integration/set/@Symfony.test

[VincentLanglet]

I think It won't be compatible with the fact the test is running in PHP 7.4

[VincentLanglet]

@keradus I don't see how to add this in Symfony.set since it must run in PHP 7.4 too.

But there is already test about this change since I needed to update the following code:
#7356 (comment)

[VincentLanglet]

Test are green and I don't think #7356 (comment) is doable until we drop 7.4 support.

Is it something else to do @Wirone @keradus ? :)