Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SelfAccessorFixer): do not touch references inside lambda and/or arrow function #7349

Merged
merged 4 commits into from Oct 31, 2023
Merged

fix(SelfAccessorFixer): do not touch references inside lambda and/or arrow function #7349

merged 4 commits into from Oct 31, 2023

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Oct 4, 2023 •
edited

closes #7163

might be best to review per commit, can extract into multiple PRs but not sure worth the trouble, let me know

@coveralls
Copy link

coveralls commented Oct 4, 2023 •
edited

Coverage Status

coverage: 94.604%. remained the same when pulling 3649d1a on SpacePossum:7163 into 7ab90e7 on PHP-CS-Fixer:master.

@SpacePossum
Copy link
Contributor Author

rebased on latest

@SpacePossum
Copy link
Contributor Author

rebased on latest, no other changes

@SpacePossum
Copy link
Contributor Author

rebased on latest, no other chatges,
this is a bug fix where a "non-risky" fixer actual breaks peoples code, so maybe someone can take a look? thanks

Wirone
Wirone requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments related to tests, but probably only one can be considered as a blocker (test case with array destructuring). Anyway, good job, let's finish it 🙂.

tests/Tokenizer/TokensAnalyzerTest.php Show resolved Hide resolved
tests/Tokenizer/TokensAnalyzerTest.php Show resolved Hide resolved
tests/Tokenizer/TokensAnalyzerTest.php Show resolved Hide resolved
tests/Tokenizer/TokensAnalyzerTest.php Outdated Show resolved Hide resolved
tests/Tokenizer/TokensAnalyzerTest.php Outdated Show resolved Hide resolved
@Wirone Wirone enabled auto-merge (squash) October 31, 2023 10:44
@Wirone Wirone merged commit 5f102b4 into PHP-CS-Fixer:master Oct 31, 2023
15 checks passed
@Wirone
Copy link
Member

Wirone commented Oct 31, 2023

Thank you @SpacePossum 🍻

@SpacePossum SpacePossum deleted the 7163 branch October 31, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

self_accessor should correctly replace self in bound closures
3 participants
@SpacePossum @coveralls @Wirone