Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: add custom tokens for Disjunctive Normal Form types parentheses #6823

Merged
merged 4 commits into from Mar 12, 2023
Merged

minor: add custom tokens for Disjunctive Normal Form types parentheses #6823

merged 4 commits into from Mar 12, 2023

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@kubawerlos kubawerlos added the topic/PHP8.2 Related to features available in PHP 8.2+ label Mar 12, 2023
@coveralls
Copy link

coveralls commented Mar 12, 2023 •
edited

Pull Request Test Coverage Report for Build 4398525717

  • 4 of 19 (21.05%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 92.847%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Tokenizer/Transformer/DisjunctiveNormalFormTypeParenthesisTransformer.php 0 15 0.0%
Totals Coverage Status
Change from base Build 4394735456: -0.06%
Covered Lines: 22715
Relevant Lines: 24465
💛 - Coveralls

kubawerlos and others added 2 commits March 12, 2023 17:58
@kubawerlos @Wirone
Apply suggestions from code review
6bd7665 
Co-authored-by: Grzegorz Korba <wirone@gmail.com>
@kubawerlos
Update tests
7647d6e
@keradus
Copy link
Member

keradus commented Mar 12, 2023

kudos @kubawerlos for PR, @SpacePossum for initial work on it, and @Wirone for great review!

@keradus keradus merged commit fb62107 into PHP-CS-Fixer:master Mar 12, 2023
@kubawerlos kubawerlos deleted the add_dnf_parentheses_custom_tokens branch March 12, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
kind/feature topic/PHP8.2 Related to features available in PHP 8.2+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @keradus @Wirone